Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upickle to 4.0.0 and remove unecessary customizations #2979

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

bugarela
Copy link
Collaborator

@bugarela bugarela commented Sep 3, 2024

Hello :octocat:

This is a replacement for #2905

I've updated upickle and ujson all the way to the most recent version (4.0.0), as that includes features for things we had to work around before. This way, I was able to remove all of the customized rw values, as macroRW works for everything now (with the proper config updates).

I've also added a couple of tests that helped me debug things, but no behavior was changed.

I checked that this version is compatible with all Quint's integration tests.

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • [-] Documentation added for any new functionality
  • [-] Entries added to ./unreleased/ for any new functionality

Comment on lines -392 to -397
// NOTE: Contrary to quint values, for quint types, source IDs are optional.
// This is because many types are inferred, and not derived from the soruce.
//
// We therefor default id to -1 in the following, because upickle handles
// optional values stupidly and if we specify `id` as `Option[Int]` it will
// require the value of the ID field to be a (possibly empty) singleton array.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the PR, this comment was just outdated (the thing it refers to no longer exists)

@bugarela bugarela requested a review from konnov September 3, 2024 20:07
Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! You have definitely made the code much easier to read!

@bugarela
Copy link
Collaborator Author

bugarela commented Sep 4, 2024

This is amazing! You have definitely made the code much easier to read!

We have @lihaoyi to thank for that! Due to the new features in 4.0.0, we got rid of a lot of custom serialization 😄

@bugarela bugarela merged commit f8a8826 into main Sep 4, 2024
10 checks passed
@bugarela bugarela deleted the gabriela/update-upickle branch September 4, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants